Handle plain string localStorage values to be able to JSON-parse them #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids any workarounds that modify the localStorage value with surrounding double quotes.
schefbi
approved these changes
Jun 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@schefbi Das ist ein Fix, der das Handling von Strings welche keine JSON Daten sind innerhalb der Kursausschreibungs-App löst, anstatt den localStorage Wert zu verändern, was grundsätzlich keine gute Idee ist und Portal-seitig zu Problemen führt.
Habe gleichzeitig die Änderung im (beim Portal) eingecheckten, minifizierten Code gemacht.