New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compatibility with adapter v0.7.0 #3
Conversation
* Adapter methods take options hash * #set and #get aliases no longer available
* :branch option to override configured adapter branch * :message option to override default commit messages * Support :actor / :author / :committer options on commits * Support :committed_date / :authored_date options on commits
Nice work! I actually haven't been using adapter for any projects recently. Would you have any interest in taking over maintenance for this? I can add you as a collaborator and give you the keys to release gems if you're interested. |
Sure, I'd be glad to pitch in. Please let me know if you need any more info from me to make this happen. |
@teleological @bkeepers has any progress been made on this front? |
Sorry, somehow this fell off my radar. I'm still willing to hand over maintenance to anyone that is interested in taking this over. |
I would be willing to take it on but do not have time to actively develop. I am willing to look over patches and tests and whatnot, though. |
Hired!!! You should have push access now, and I added you as an owner to release new gems. |
Wow! Okay, sounds great! @bkeepers this patch looks good to me. What do you think? It /is/ the first patch I'm approving, after all. |
The diff looks good to me, but it might be good to pull it down locally and make sure the tests pass. |
Works fine but only when I tested on 1.9.3 (as opposed to the 2.2.2 I have installed). |
Also, Travis agrees. |
Compatibility with adapter v0.7.0
key_for is no longer implemented in Adapter. I re-added it as #seralize_key.