Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with adapter v0.7.0 #3

Merged
merged 2 commits into from Jul 8, 2015

Conversation

teleological
Copy link
Contributor

  • Adapter methods take options hash
  • #set and #get aliases no longer available

key_for is no longer implemented in Adapter. I re-added it as #seralize_key.

* Adapter methods take options hash
* #set and #get aliases no longer available
* :branch option to override configured adapter branch
* :message option to override default commit messages
* Support :actor / :author / :committer options on commits
* Support :committed_date / :authored_date options on commits
@bkeepers
Copy link
Owner

Nice work! I actually haven't been using adapter for any projects recently. Would you have any interest in taking over maintenance for this? I can add you as a collaborator and give you the keys to release gems if you're interested.

@teleological
Copy link
Contributor Author

Sure, I'd be glad to pitch in. Please let me know if you need any more info from me to make this happen.

@tekknolagi
Copy link
Collaborator

@teleological @bkeepers has any progress been made on this front?

@bkeepers
Copy link
Owner

bkeepers commented Jul 7, 2015

Sorry, somehow this fell off my radar.

I'm still willing to hand over maintenance to anyone that is interested in taking this over.

@tekknolagi
Copy link
Collaborator

I would be willing to take it on but do not have time to actively develop. I am willing to look over patches and tests and whatnot, though.

@bkeepers
Copy link
Owner

bkeepers commented Jul 8, 2015

I would be willing to take it on but do not have time to actively develop. I am willing to look over patches and tests and whatnot, though.

Hired!!! You should have push access now, and I added you as an owner to release new gems.

@tekknolagi
Copy link
Collaborator

Wow! Okay, sounds great! @bkeepers this patch looks good to me. What do you think? It /is/ the first patch I'm approving, after all.

@bkeepers
Copy link
Owner

bkeepers commented Jul 8, 2015

The diff looks good to me, but it might be good to pull it down locally and make sure the tests pass.

@tekknolagi
Copy link
Collaborator

Works fine but only when I tested on 1.9.3 (as opposed to the 2.2.2 I have installed).

@tekknolagi
Copy link
Collaborator

Also, Travis agrees.

tekknolagi added a commit that referenced this pull request Jul 8, 2015
Compatibility with adapter v0.7.0
@tekknolagi tekknolagi merged commit 36e9420 into bkeepers:master Jul 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants