Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse multiline values #318

Merged
merged 5 commits into from Apr 13, 2018

Conversation

joelvh
Copy link
Contributor

@joelvh joelvh commented Jan 13, 2018

These minor changes allow for successfully parsing config variables exported from Heroku.

@joelvh
Copy link
Contributor Author

joelvh commented Jan 22, 2018

@bkeepers any interest in merging this? Fixes multi-line value parsing, such as using heroku config:pull to parse multi-line values from Heroku. This was not working without these updates.

Thanks!

@joelvh
Copy link
Contributor Author

joelvh commented Mar 1, 2018

@bkeepers is there no interest in merging this? It addresses the issue of not being able to use a .env file dumped from Heroku which have multi-line values, which I'm sure many people deal with. Thanks!

@cadwallion cadwallion self-assigned this Apr 13, 2018
@cadwallion
Copy link
Collaborator

👋 @joelvh !

Apologies for this languishing. I'm part of a trio of new maintainers and our first order of business is getting caught up on the outstanding and stale PRs. I just wanted to let you know I'm reviewing it shortly, and to thank you for the contribution.

@joelvh
Copy link
Contributor Author

joelvh commented Apr 13, 2018

@cadwallion thanks for taking a look!

@cadwallion
Copy link
Collaborator

This looks good, merging. Thank you for the contribution!

@cadwallion cadwallion merged commit aaabca8 into bkeepers:master Apr 13, 2018
@joelvh
Copy link
Contributor Author

joelvh commented Apr 13, 2018

@cadwallion thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants