Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the latest Rubies on Travis CI #387

Merged
merged 1 commit into from Jun 15, 2019

Conversation

koic
Copy link
Contributor

@koic koic commented May 6, 2019

@siegy22
Copy link
Contributor

siegy22 commented May 6, 2019

How about we just specify the minor version? 😄 like 2.4 and 2.6

@koic
Copy link
Contributor Author

koic commented May 6, 2019

I'm not sure whether to behave with the expected tiny version if I omit the tiny version.
rails/rails#29232 (comment)

@siegy22
Copy link
Contributor

siegy22 commented May 6, 2019

The only difference here is, it will automatically pick the latest 2.x version without having to bump it with every patch level release in the travis file. I'd assume it's fair to pin only the minor version and if a tests starts failing because of that automatic update, then I would be concerned about the ruby release itself and not the compatibility with this gem. 😄

In general there are two approaches:
1: Bump patch version if a ruby version was released

2: Specify only the minor version; if the build fails because of the latest version, pin it down and fix it. and then re-pin to the minor version to use automatically the newest version.

I don't wanna blame you or anything it's just a step that someone has do to manually, and that just generates more work for a gem to maintain.

@koic
Copy link
Contributor Author

koic commented May 8, 2019

I see. It seems to be able to target the entire .travis.yml configuration in this repository. So I wait for the maintainer's decision. Thank for your explanation.

@cadwallion
Copy link
Collaborator

Apologies for the delayed response on this. I'm content with merging this in as-is for now and we'll bump up manually as releases come out.

@cadwallion cadwallion merged commit 5c812db into bkeepers:master Jun 15, 2019
@koic koic deleted the use_latest_rubies_on_travis_ci branch June 15, 2019 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants