reconnect on Connection Failure in MongoDB + dead workers cleanup on startup #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added 2 config values: 1. Qu.max_retries_on_connection_failure - maximum retries on connection failure default: 5 2. Qu.retry_frequency_on_connection_failure - retry frequency in seconds between tries. Backend will retry to reconnect in current_try_number * frequency. e.g.: If Qu.max_retries_on_connection_failure = 5 and Qu.retry_frequency_on_connection_failure = 2 will retry 5 times after 2,4,6,8 and 10 seconds. default: 1
Check if all registered workers on own host is launched, and unregister dead workers.
|
Uffff. "GitHub Flavored Markdown" make me crazy :(. |
|
You want to cherry-pick reconnect commit? |
|
Sorry for the delay on pulling this. I haven't pulled it yet because I don't like the extra options that are currently only mongodb specific being added to the Qu module. I want to refactor a few things to declare most options directly on the backend. I'll try to get to it today or tomorrow. |
|
Merged reconnect code and move config variables directly into backend. 9c4f2be Thanks again for the pull request! How has Qu been working for you? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi.
Implemented reconnect on Connection Failure in MongoDB backend.
This is useful in production with replica sets, since it take 2-10 seconds to replica set to elect new master.
I don't use redis so I don't implemented this for redis adapter.
Also added 2 config values: Qu.max_retries_on_connection_failure and Qu.retry_frequency_on_connection_failure, it would be great to add them to read me.
Implemented Dead workers cleanup on startup.
Used unregister_worker so will not work due issue exception in unregister_worker #13.
After you decide what you want to pass to unregister_worker method you need to change worker to worker.id on line 87 in worker.rb if you decide to pass id, or do nothing if you decide to pass worker object.
Thanks.