Fix for issue 64 and mongo > 1.8.3 #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…option It seems mongo-ruby-driver v1.8.4 switched from strings to symbols when referencing the MongoClient::@auths hash mongodb/mongo-ruby-driver@6428bf6#L1L244
Starting in Mongo 1.8.4 the keys of the auths hash are symbols. The qu-mongo backend probably shouldn't care how mongo keys its hashes so I updated the code to avoid manipulating auths directly. Also, the Connection class appears to be deprecated so I updated this to use the replacement MongoClient instead.
bkeepers
added a commit
that referenced
this pull request
Jul 8, 2013
Fix for issue 64 and mongo > 1.8.3
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like some changes in mongo 1.8.4 broke qu-mongo backend as noted in issue #64. This pull request fixes the issue. I tested mongo 1.8.6 and 1.8.3 and the changeset works for both and all the tests pass on both.