Hooks #69
Merged
Hooks #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* master: Make poll timer configurable in mongo backend Preparing for 0.1.3 release Move mongo specific configs into the backend Implemented reconnect on Connection Failure in MongoDB backend. Update ChangeLog Update docs for Rails 2 Updated README to include instructions for non-Railtie usage. Only use railtie if Rails::Railtie is defined (Rails 3) Delete jobs when clearing the queue in redis
Typo fix
Conflicts: lib/qu/payload.rb spec/qu/payload_spec.rb spec/spec_helper.rb
No need to define empty methods. Instead, they get default behavior that is overridable.
|
Oh man, this was so long ago that I don't remember. I remember that I wasn't quite satisfied with how this worked, but I don't remember why. Sorry, I'm not much help. :) |
|
No problem. From what I've read it looks like you just wanted to try it in speakerdeck or something. I'll play with it and make a decision. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this code gets any more stale than it is, I would like to get it into master. I brought it up to date tonight and tweaked a few things.
@bkeepers do you remember anything else you wanted to do with this? Or maybe just start with this and move on from there?