Create separate class to execute jobs #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a proposal for bkeepers#5. Creates a separate class to execute the job instead of doing the execution inside the worker. This allows us to have different execution mechanisms, from the current "just run", to a forking runner and in the future other threaded runners (that would be better suited for JRuby and Rubinius).
| @@ -70,4 +71,4 @@ def self.running?(service) | |||
| end | |||
| end | |||
|
|
|||
| Qu.logger = Logger.new('/dev/null') | |||
| Qu.logger = Logger.new(STDOUT) | |||
There was a problem hiding this comment.
This makes it really dirty when running the tests. I'm thinking maybe we do an ENV var flag to log to stdout vs nowhere. That would keep tests to dots by default but allow flipping to verbose output. The first time I ran the tests locally I thought that things failed and then realized they didn't.
jnunemaker
pushed a commit
that referenced
this pull request
Feb 17, 2014
Create separate class to execute jobs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposal for #5. Creates a separate class to execute the job instead of doing the execution inside the worker. This allows us to have different execution mechanisms, from the current "just run", to a forking runner and in the future other threaded runners (that would be better suited for JRuby and Rubinius).
This is far from being a full implementation (and still lacks tests for forking more than one worker at a time) but I think it would be nice to have it here so we can discuss this before I dig deeper into the rabbit hole.