Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NSQ HTTP backend #97

Closed
wants to merge 4 commits into from
Closed

NSQ HTTP backend #97

wants to merge 4 commits into from

Conversation

grantr
Copy link
Collaborator

@grantr grantr commented Oct 10, 2014

This backend supports the NSQ HTTP api with no extra dependencies. It can only push, get queue size, and clear queues.

I split the backend shared specs internally into pushing specs (push, size, clear) and other. Future shared push specs should go in the a pushing backend group.

/cc @jnunemaker @bkeepers

Only supports push, size, and clear. For producers that don't want to
deal with nsq client libraries.
@jnunemaker
Copy link
Collaborator

The extra dependency would only be required for dev and for the nsq gemspec. I'd rather use a supported client library and have an extra dep than support a custom one long term. Thoughts?

@grantr
Copy link
Collaborator Author

grantr commented Oct 12, 2014

@jnunemaker sorry for the confusion! This isn't the full NSQ backend. This is only an alternative for those scared of celluloid. It turned out to be easier to write than the real one.

A true NSQ backend (with krakow as the client library) is in progress at https://github.com/grantr/qu/tree/nsq. It works, but there are timing issues with the specs that I haven't resolved yet. I'll create a PR for that when it's ready.

@jnunemaker
Copy link
Collaborator

@bkeepers can you add @grantr to qu or add me in some way that I can access settings? Seems easier to have him just work on qu in branches, rather than a fork.

@bkeepers
Copy link
Owner

Do you see NSQ being commonly used? I'm just wondering if it should just be in a separate repo. I don't feel strongly either way, but I know in the past we've tried to limit the officially supported backends.

@bkeepers can you add @grantr to qu or add me in some way that I can access settings?

Added him. I guess you can't give admin access to contributors on personal repos?

@jnunemaker
Copy link
Collaborator

Yeah, I'd be cool with separate gem for nsq as well.

@grantr
Copy link
Collaborator Author

grantr commented Oct 13, 2014

I actually think everything but qu-redis should be a separate repo. Can we create a qu org?

@jnunemaker
Copy link
Collaborator

Stale.

@jnunemaker jnunemaker closed this May 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants