-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes #7 Add support for Elixir Phoenix #8
Conversation
846cb05
to
2e5a900
Compare
Definitely. Any suggestions on what the heuristics should be for detecting npm vs phoenix? |
996f5f2
to
997dfae
Compare
By default Phoenix doesn't define a |
997dfae
to
d5e53f1
Compare
plugins/3-npm.sh
Outdated
@@ -1,6 +1,7 @@ | |||
#!/usr/bin/env bash | |||
|
|||
test -f package.json || return 1 | |||
NPM_START_SCRIPT=$(grep "\"start\":" package.json) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if I have a package.json
for node that doesn't have a start
script? This is pretty common in npm modules.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe have the more specific check only for the server command?
d5e53f1
to
c74e838
Compare
c74e838
to
cf99b94
Compare
Thanks @fapdash. I pushed a few fixes after testing it locally, but everything looks good now. |
@bkeepers All the commands are working except for
strappy server
.Phoenix projects have a
package.json
file in the top directory and so thenpm_server
command is triggered.Would it be possible to make the
npm_server
check more specific?