Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated sequelize to updated #1569

Merged
merged 1 commit into from Jan 27, 2021
Merged

updated sequelize to updated #1569

merged 1 commit into from Jan 27, 2021

Conversation

cigar-galaxy82
Copy link
Contributor

No description provided.

@cigar-galaxy82
Copy link
Contributor Author

error in e2e test "This version of ChromeDriver only supports Chrome version 88".
Same thing happened in my local os so I updated my ChromeDriver to version 88 and it's working fine

@bkimminich
Copy link
Member

The problem is, that GitHub still delivers Chrome 87 because they update only once per week. Happens only rarely, but it should be fixed latest in a few days.

@cigar-galaxy82
Copy link
Contributor Author

Ok I'll try this again in few days

@bkimminich
Copy link
Member

I assume the 4-year old https://www.npmjs.com/package/sequelize-noupdate-attributes extension did not work with v6 of sequelize so you switched it to https://www.npmjs.com/package/sequelize-notupdate-attributes which works? Did you test for any side effects or unexpected behavior changes which might not be covered by our test suite?

@cigar-galaxy82
Copy link
Contributor Author

cigar-galaxy82 commented Jan 27, 2021

The message that it returns was different and the status code

@bkimminich bkimminich merged commit 4b9dceb into juice-shop:develop Jan 27, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants