Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task: Conform to RFC-356 #59

Merged
merged 9 commits into from
Oct 31, 2023
Merged

Task: Conform to RFC-356 #59

merged 9 commits into from
Oct 31, 2023

Conversation

bkonkle
Copy link
Owner

@bkonkle bkonkle commented Oct 25, 2023

Closes #56

@bkonkle bkonkle changed the title Wide range of changes to adapt to the new style Task: Conform to RFC-356 Oct 25, 2023
@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Merging #59 (736f553) into main (a9c8da5) will increase coverage by 13.16%.
The diff coverage is 75.00%.

@@             Coverage Diff             @@
##             main      #59       +/-   ##
===========================================
+ Coverage   51.12%   64.29%   +13.16%     
===========================================
  Files          30       30               
  Lines        1905     2176      +271     
===========================================
+ Hits          974     1399      +425     
+ Misses        931      777      -154     
Files Coverage Δ
nakago/derive/src/provider.rs 100.00% <100.00%> (ø)
nakago/src/config/hooks.rs 85.26% <100.00%> (+85.26%) ⬆️
nakago/src/config/loader.rs 90.00% <100.00%> (+90.00%) ⬆️
nakago/src/inject/container.rs 93.82% <ø> (+19.75%) ⬆️
nakago/src/inject/injector.rs 92.85% <ø> (ø)
nakago/src/inject/provider.rs 89.83% <ø> (ø)
nakago/src/lifecycle.rs 93.33% <100.00%> (+93.33%) ⬆️
nakago_axum/src/routes.rs 0.00% <0.00%> (ø)
nakago_axum/src/test/http.rs 0.00% <0.00%> (ø)
nakago/src/app.rs 57.72% <95.23%> (+57.72%) ⬆️
... and 14 more

@bkonkle bkonkle marked this pull request as ready for review October 31, 2023 22:05
@bkonkle bkonkle merged commit 51c4257 into main Oct 31, 2023
5 checks passed
@bkonkle bkonkle deleted the feature/56-rfc-356 branch October 31, 2023 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Task: Conform to RFC-356
1 participant