Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Better Figment Config #89

Merged
merged 5 commits into from
Jan 26, 2024
Merged

Feature: Better Figment Config #89

merged 5 commits into from
Jan 26, 2024

Conversation

bkonkle
Copy link
Owner

@bkonkle bkonkle commented Jan 24, 2024

Changed

  • Moved config loaders to act on Figments, making it easy to take full advantage of the Figment library.

Copy link

codecov bot commented Jan 24, 2024

Codecov Report

Attention: 42 lines in your changes are missing coverage. Please review.

Comparison is base (6cab1a1) 51.11% compared to head (e6951d4) 54.37%.

Files Patch % Lines
nakago_sea_orm/src/config.rs 0.00% 10 Missing ⚠️
nakago/src/inject/tag.rs 83.72% 7 Missing ⚠️
nakago/src/inject/type_id.rs 83.72% 7 Missing ⚠️
nakago_axum/src/auth/config.rs 0.00% 6 Missing ⚠️
nakago_warp/src/auth/config.rs 0.00% 6 Missing ⚠️
nakago_axum/src/config.rs 0.00% 3 Missing ⚠️
nakago_warp/src/config.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #89      +/-   ##
==========================================
+ Coverage   51.11%   54.37%   +3.25%     
==========================================
  Files          49       49              
  Lines        2680     2801     +121     
==========================================
+ Hits         1370     1523     +153     
+ Misses       1310     1278      -32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bkonkle bkonkle merged commit bbf0792 into main Jan 26, 2024
5 checks passed
@bkonkle bkonkle deleted the feature/more-features branch January 26, 2024 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant