New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for Z-Way Authentication token. #11
Conversation
Could somebody test it? I have no hardware anymore |
If you give me a simple instruction on how to install node-red and this module, I can. But note, that I've ZERO experience in node-red |
I could test it. I have rpi running with nodered. But I dont have any idea on how to get the fork/pull-request from Github into nodered. |
Ok guys, sorry for such a big delay. Will test it and update plugin |
I tested this, but I need to enter token in the config-node of zway, I used a token grabbed from zway web interface, but that crashes node-red |
The token is the right one (from Z-Way web UI). I fear my fixes made "in blind" were not correct and that lead to the error. Maybe @bkorda can fix it. If not, we add it to our long queue of tasks. |
Tested on latest Zway release (3.2.2.) as well, still does not work and causes a crash of node-red. |
@PoltoS , can you check on above please ? maybe it provides some insights.... debug log is there. |
I can just try-and-fail if you provide me direct access via SSH and web UI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested this one, still crashes node-red in docker
Try to remove every server (configuration) node from flow, deploy changes, add a new server node. |
Ok, I’ll try that later
From: Bohdan Korda ***@***.***>
Sent: maandag 13 december 2021 12:37
To: bkorda/node-red-contrib-zway ***@***.***>
Cc: Vinisz ***@***.***>; Comment ***@***.***>
Subject: Re: [bkorda/node-red-contrib-zway] Added support for Z-Way Authentication token. (#11)
Try to remove every server (configuration) node from flow, deploy changes, add a new server node.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub <#11 (comment)> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/AL2YLJAAOIOHXKR7KRAD3R3UQXLFLANCNFSM5DRGYA3A> .
Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub> . <https://github.com/notifications/beacon/AL2YLJF7BZZNT2FMM4HUJELUQXLFLA5CNFSM5DRGYA3KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOHMTHHNI.gif>
|
@bkorda , tried directly on the RPI, so node-red and Zway running on same device, same issue, here is the output from the RPI 13 Dec 16:04:01 - TypeError: Cannot read property 'devices' of null |
Looks like if the token is wrong (missing / or just expired), the answer will be null (403) and as a result node_red crashes. May be it is worth to add such a check not to crash node-red. |
Starting from v3.2.0 Z-Way requires Websocket API to be authenticate like HTTP API. This changes the node-red integration module to use the Z-Way auth token instead of login/pass.
You can change back to login/pass and autodetect the token from the first discoverDevices. Up to you
NB! This was not tested - please check before merging.
Should fix: #10