Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

next_slug_sequence falsely adds -1 to short names... #15

Closed
subimage opened this issue Feb 13, 2014 · 1 comment
Closed

next_slug_sequence falsely adds -1 to short names... #15

subimage opened this issue Feb 13, 2014 · 1 comment

Comments

@subimage
Copy link

Ran into this on a music genre project I'm working on.

I have a table with genres like

Rap Metal
Rap Rock
Rap

If I iterate through them and 'Rap Metal' has already saved a slug as 'rap-metal', then 'Rap' will save slug as 'rap-1' due to the 'LIKE' SQL fragment in next_slug_sequence
@bkoski
Copy link
Owner

bkoski commented Nov 11, 2018

Thanks for reporting!

This is now fixed, thanks to the logic updates in #17 and PR #6

This case is now tested in a31a59c

@bkoski bkoski closed this as completed Nov 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@subimage @bkoski