Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Up should accept options struct #1

Closed
bkosm opened this issue Feb 1, 2023 · 1 comment
Closed

Up should accept options struct #1

bkosm opened this issue Feb 1, 2023 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@bkosm
Copy link
Owner

bkosm commented Feb 1, 2023

Parameters to the Up function should accept a struct rather than a required param and varargs.


Turn this:

err = gompose.Up(
	gompose.ReadyOnLog("database system is ready to accept connections", 2),
	func() { _ = gompose.Down() }, // any action to be taken on system interrupt
)

Into this:

err = gompose.Up(
        gompose.UpOpts {
              WaitOnChannel: gompose.ReadyOnLog("database system is ready to accept connections", 2),
              OnInterrupt: func() { _ = gompose.Down() },
        }
)
@bkosm bkosm added enhancement New feature or request good first issue Good for newcomers labels Feb 1, 2023
bkosm pushed a commit that referenced this issue Feb 11, 2023
@bkosm
Copy link
Owner Author

bkosm commented Feb 11, 2023

done in v0.2.0

@bkosm bkosm closed this as completed Feb 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant