Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node Children #36

Closed
3 tasks
Emsu opened this issue Oct 14, 2017 · 2 comments
Closed
3 tasks

Node Children #36

Emsu opened this issue Oct 14, 2017 · 2 comments

Comments

@Emsu
Copy link
Contributor

Emsu commented Oct 14, 2017 •
edited

As a separate prop maybe called children it would be great to pass children into the nodeSvgShape to allow for SVG nodes that are more complex than a shape.

I may be able to get the implementation working but might need some help.

  • Implementation
  • Unit test
  • Docs
@bkrem bkrem mentioned this issue Oct 14, 2017
Merged
@bkrem bkrem mentioned this issue Oct 21, 2017
Closed
3 tasks
@bkrem bkrem mentioned this issue Nov 29, 2017
Closed
3 tasks
@bkrem
Copy link
Owner

bkrem commented Jan 17, 2018

@Emsu In case this is still relevant for you, could you please check out v1.8.0's nodeLabelComponent feature to see if it meets your use case?

@Emsu
Copy link
Contributor Author

Emsu commented Jan 17, 2018

hey @bkrem thanks! I'll check it out

@bkrem bkrem closed this as completed Feb 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Emsu @bkrem