Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom pathFunc #37

Closed
3 tasks done
Emsu opened this issue Oct 14, 2017 · 1 comment
Closed
3 tasks done

Custom pathFunc #37

Emsu opened this issue Oct 14, 2017 · 1 comment

Comments

@Emsu
Copy link
Contributor

Emsu commented Oct 14, 2017

Besides elbow, diagonal, and straight, would be great to pass a custom func. My use case is an elbow like func with 4 segments instead of 2.

Looks like we can just add function as an acceptable propType in the enum and call the function if a function is given otherwise check for 'straight', 'diagonal', and 'elbow' as is currently done.

  • Implementation
  • Unit test
  • Docs
bkrem pushed a commit that referenced this issue Oct 18, 2017
* Allow functions as a possible pathFunc.

* Updated `pathFunc` proptype on `Tree`

Note: Added package-lock.json
@bkrem bkrem added this to the v1.6.0 milestone Oct 18, 2017
bkrem added a commit that referenced this issue Oct 21, 2017
bkrem added a commit that referenced this issue Oct 21, 2017
@bkrem bkrem removed this from the v1.6.0 milestone Oct 21, 2017
@bkrem
Copy link
Owner

bkrem commented Oct 21, 2017

Hey @Emsu,

Finally released this in v1.5.1, so I'll be closing the issue.

Thank you for your contribution and keen to see what can be done about #36! :)

@bkrem bkrem closed this as completed Oct 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants