Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure support for React 16 #39

Closed
3 tasks
bkrem opened this issue Oct 14, 2017 · 7 comments
Closed
3 tasks

Ensure support for React 16 #39

bkrem opened this issue Oct 14, 2017 · 7 comments

Comments

@bkrem
Copy link
Owner

bkrem commented Oct 14, 2017

  • Implementation
  • Unit test
  • Docs
@bkrem bkrem added this to the v1.6.0 milestone Oct 18, 2017
@bkrem bkrem removed this from the v1.6.0 milestone Oct 31, 2017
@jmorrice
Copy link

jmorrice commented Nov 2, 2017

+1! Quite a few issues mainly related to paths since updating

@bkrem
Copy link
Owner Author

bkrem commented Nov 2, 2017

Ok, can you explain what's going on @jmorrice?

@jmorrice
Copy link

jmorrice commented Nov 2, 2017

  • All paths are being shown right away, without the corresponding nodes.
  • Nodes aren't collapsing after clicking them again

I'll see if I can figure out what's going on

@bkrem
Copy link
Owner Author

bkrem commented Nov 2, 2017

Ok interesting. That would be great if you have a few minutes 👏

Will push out a new version ASAP if you have a PR at some point, otherwise I'll investigate myself.

@bkrem
Copy link
Owner Author

bkrem commented Nov 19, 2017

@jmorrice can't see any obvious issues after upgrading the demo to react/react-dom 16.x, could you please post the setup you're using the library in?

@jmorrice
Copy link

My mistake, turns out the problem was related to updating react-transition-group from 1.1.3 to 2.2.1. So we can close this issue, but shall I open another ticket for updating that package?

@bkrem
Copy link
Owner Author

bkrem commented Nov 22, 2017

Ok, suspected that might have been the reason.

Sure feel free to open an issue for an upgrade to transition-group v2.

It should actually be declared as a peer dependency rather than a direct dependency anyways, as it can cause hard to track bugs this way.
That’s a breaking change though so will have to wait until react-d3-tree v2. Refactoring and upgrading should hopefully be possible now though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants