fix: treat node with empty children as leaf #408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @zhouhao, Sorry about the wait, it's been a very busy week. Agreed and this all looks great! Will try to get a patch release out for this in the next 24hrs. I also think there is an issue open for this, which I'll link. |
bkrem
approved these changes
Oct 22, 2022
|
Closes #395 |
bkrem
changed the title
|
Published as https://github.com/bkrem/react-d3-tree/releases/tag/v3.3.5 Thanks again for the fix! 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @bkrem, thank you for your great package.
I feel it makes more sense here to treat node with empty children as leaves.
WDYT?