fix: add touchmove event #448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adeams1805
force-pushed
the
feature/draggable-false-mobile
branch
from
5de90e2
to
20fdc56
Compare
bkrem
approved these changes
Mar 17, 2023
|
Thank you for taking the time to fix this @Adeams1805 🙏 I have some catching up to do on this repo. Been swamped with professional responsibilities + out sick during the last few weeks, at the cost of any OSS contributions and addressing issues here (even this silly 1 liner bug!). |
|
Fixed in https://github.com/bkrem/react-d3-tree/releases/tag/v3.5.1 Thanks again 💯 |
|
No worries ! I'm glad I was able to contribute 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The props draggable=false desn't work on mobile because the event is not "mousemove" but "touchmove".
I encountered the bug myself and saw this opened issue
Not a big change, just one line, but very needed in my opinion !