Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect condition on zoom event #455

Closed
wants to merge 1 commit into from

Conversation

Liu233w
Copy link

@Liu233w Liu233w commented Apr 11, 2023

If we double click and drag the canvas, there will be an event that does not meet the condition and the function does not return before the attr call, so the tree is re-positioned even if draggable is false.

If we double click and drag the canvas, there will be an event that does not meet the condition and the function does not return before the attr call, so the tree is re-positioned even if draggable is false.
@bkrem
Copy link
Owner

bkrem commented Apr 12, 2023

Thank you for raising this 🙏

Your suggestion broke the draggability even when draggable was enabled. Based on your feedback I added the dblclick event to the checks though and published as part of https://github.com/bkrem/react-d3-tree/releases/tag/v3.5.2

Need to close this unfortunately but cknowledged you in the release notes :)

@bkrem bkrem closed this Apr 12, 2023
@Liu233w
Copy link
Author

Liu233w commented Apr 13, 2023

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants