Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating Typing for the new method "addChildren" #461

Merged
merged 2 commits into from
May 12, 2023
Merged

Updating Typing for the new method "addChildren" #461

merged 2 commits into from
May 12, 2023

Conversation

dev-john-nguyen
Copy link
Contributor

This is an addition to this MR, #417.

Need to update the type properties for CustomNodeElementProps to include addChildren.

bkrem
bkrem reviewed May 12, 2023
View reviewed changes
src/types/common.ts Outdated Show resolved Hide resolved
bkrem
bkrem approved these changes May 12, 2023
View reviewed changes
Copy link
Owner

@bkrem bkrem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch thank you 👍

@bkrem bkrem merged commit cc88ad3 into bkrem:master May 12, 2023
2 checks passed
@bkrem
Copy link
Owner

bkrem commented May 12, 2023

🚢 https://github.com/bkrem/react-d3-tree/releases/tag/v3.6.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkrem bkrem bkrem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dev-john-nguyen @bkrem