Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Uncaught TypeError: date.getDay is not a function in @d3fc/d3fc-d… #1

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

bl5ck
Copy link
Owner

@bl5ck bl5ck commented Jan 4, 2024

Fix Uncaught TypeError: date.getDay is not a function in @d3fc/d3fc-discontinuous-scale/**/skipWeekends.js

When combine VictoryVoronoiContainer with

scaleDiscontinuous(
    d3Scale.scaleTime()
  ).discontinuityProvider(discontinuitySkipWeekends())

there would be an error: TypeError: date.getDay is not a function when hovering the Chart

…iscontinuous-scale/**/skipWeekends.js

When combine VictoryVoronoiContainer with 
scaleDiscontinuous(
    d3Scale.scaleTime()
  ).discontinuityProvider(discontinuitySkipWeekends())

there would be an error: TypeError: date.getDay is not a function
when hovering the Chart
@bl5ck bl5ck merged commit 28f0d88 into main Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant