Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-account container long click menu doesn't work (but right click menu works) #114

Closed
4 of 11 tasks
adnan360 opened this issue Jul 4, 2021 · 4 comments
Closed
4 of 11 tasks
Labels
Class::Layout-Others Layout issues except Padding and Size issues Class::SideEffect Unexpected side effect, undefined behavior Component::Context-Menu Only for context menu Difficult::Hard Issues that are difficult to solve or impossible Env::Linux Issues on Linux Issue::Bug Something isn't working Priority::High Solve and focus on it first

Comments

@adnan360
Copy link

adnan360 commented Jul 4, 2021

Describe the bug
When Lepton is installed and Firefox multi-account container addon is installed, I can't open a specific container tab by long clicking the New tab button. It doesn't do anything when I select a menu item. But surprisingly if I right click the new tab button and select anything, it seems to work.

Steps to reproduce:

  • Install multi-account containers addon
  • Install Lepton on profile directory (user.js + chrome dir) and clear startup cache as instructed
  • After browser restarted, long (left) click until the containers menu appears, then click a container (e.g. Work)

Current behavior

Menu disappears, doesn't open a new tab or manage containers as if I didn't click anything

Expected behavior

Open the selected container tab or manage containers settings when clicked on a menu item

Screenshots
N/A

Environment (please complete the following information):

  • Distribution
  • Firefox Version: 89.0.2
  • OS:
    • Linux
    • Windows
    • Mac
    • Others: FreeBSD
  • Theme:
    • Light
    • Dark
    • Alpenglow(System: Light)
    • Alpenglow(System: Dark)
    • System Default
      • GTK Theme Name(Only Linux User): Adwaita

Additional context
I tested in Librewolf Appimage on Linux, but Firefox on FreeBSD. I've tried from latest release (2.1.0) and latest master (a631555). Both gave same results. Without Lepton installed left click menu works fine.

@adnan360 adnan360 added the Issue::Bug Something isn't working label Jul 4, 2021
@black7375 black7375 added Class::Layout-Others Layout issues except Padding and Size issues Component::Context-Menu Only for context menu Env::Linux Issues on Linux Priority::High Solve and focus on it first labels Jul 4, 2021
@black7375
Copy link
Owner

black7375 commented Jul 4, 2021

I checked that it closes when I lose focus, don't click ..etc
That's interesting how this can happen with CSS alone.


Investigation result

What causes symptoms to occur:

#tabs-newtab-button:not(:hover)::before {

Eventually, we must add elements after the last tab, as follows:

  #tabbrowser-arrowscrollbox:not([overflowing]) .tabbrowser-tab:not([visuallyselected], [multiselected], :hover)[last-visible-tab] .tab-background::after {
    /* Box Model */
    content:  "";
    display: block;
    position: absolute;

    /* Position */
    top:       50%;
    transform: translateX(-2.5px) translateY(calc(-50% + 1px));

    /* Bar shape */
    width:     1px;
    height:   20px;
    overflow: hidden;

    /* Bar Color */
    opacity: var(--tab-separator-opacity);
    transition: opacity .2s var(--ease-basic);
    background-color: color-mix(in srgb, currentColor 20%, transparent); /*  Replace var(--toolbarseparator-color) - Hard coded for compatibility */
  }

  .tabbrowser-tab[last-visible-tab] .tab-background::after {
    right: 0;
    transform: translateX(2px) translateY(calc(-50% + 1px)) !important;
  }

However, it is very tricky to find a way to disable it only when an interaction occurs on an element right after.

@black7375 black7375 added Issue::Help-Wanted Extra attention is needed Difficult::Hard Issues that are difficult to solve or impossible labels Jul 4, 2021
@black7375
Copy link
Owner

Are you try with this patch?


Advice of qaz69wsx
https://www.reddit.com/r/FirefoxCSS/comments/oelg2r/interesting_css_bug/

@black7375
Copy link
Owner

It is currently determined to have been fixed and will be closed.

@black7375 black7375 removed the Issue::Help-Wanted Extra attention is needed label Jul 9, 2021
@adnan360
Copy link
Author

adnan360 commented Jul 9, 2021

Yeah. Solved, thanks.

@black7375 black7375 added the Class::SideEffect Unexpected side effect, undefined behavior label Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Class::Layout-Others Layout issues except Padding and Size issues Class::SideEffect Unexpected side effect, undefined behavior Component::Context-Menu Only for context menu Difficult::Hard Issues that are difficult to solve or impossible Env::Linux Issues on Linux Issue::Bug Something isn't working Priority::High Solve and focus on it first
Projects
None yet
Development

No branches or pull requests

2 participants