Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accent color not applied in Firefox 103 beta #433

Closed
3 of 13 tasks
Farow opened this issue Jul 12, 2022 · 5 comments
Closed
3 of 13 tasks

Accent color not applied in Firefox 103 beta #433

Farow opened this issue Jul 12, 2022 · 5 comments
Labels
Browser::Upstream Changes or bugs from Firefox Class::Color Color, background, blur, etc. Component::Tabbar Tab or tabbar Env::Windows Issues on Windows10, Windows11, unknown windows Issue::Bug Something isn't working

Comments

@Farow
Copy link

Farow commented Jul 12, 2022

Describe the bug
After updating to version 103, the accent color is no longer applied on the window/tab bar.

Environment:

user.js setup

// Default settings
@Farow Farow added the Issue::Bug Something isn't working label Jul 12, 2022
@black7375 black7375 added Env::Windows Issues on Windows10, Windows11, unknown windows Class::Color Color, background, blur, etc. Component::Tabbar Tab or tabbar labels Jul 13, 2022
@black7375
Copy link
Owner

It seems to work on my device.
Try to install theme in the latest version.
Win10-2022-07-19-02-02-31

Related: #382

@black7375 black7375 added the Browser::Upstream Changes or bugs from Firefox label Jul 18, 2022
@Farow
Copy link
Author

Farow commented Jul 19, 2022

Is the accent color applied if dark mode is active? Just to clarify, I mean the accent color from windows. In the following screenshot you can see it's applied on the about dialog (brown titlebar) but not on the main window.

2022-07-19_150337

If it works again in 104 that's great. I'll test when it hits beta and let update the issue.

@black7375
Copy link
Owner

A related commit has been found. mozilla/gecko-dev@4c5f201
I think it's going to be a breaking change.

@Farow
Copy link
Author

Farow commented Jul 19, 2022

The new commit fixes the issue, thanks!

@Nomes77
Copy link
Contributor

Nomes77 commented Jul 22, 2022

I have now a little of a strange problem. It doesn't matter if I make a new profile, refresh my profile or install firefox dev on window 10.
The problem is that when -moz-accent-color is set for a variable, like --uc-accent-color: -moz-accent-color firefox loads the variable, but strangely doesn't set its accent color.
If I change -moz-accent-color to a color like red it works, but -moz-accent-color doesn't work.
-moz-accent-color only works when applied directly, without using it via a variable.
The problem occurs not only at the titlebar but also when userContent.page.proton_color.system_accent is set true

(I have FireFox 102.0.1)

Made a new profile with the default .css folowing your intallation guide vs with it should look
afbeelding
afbeelding

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Browser::Upstream Changes or bugs from Firefox Class::Color Color, background, blur, etc. Component::Tabbar Tab or tabbar Env::Windows Issues on Windows10, Windows11, unknown windows Issue::Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants