Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Photon-styled navigation button doesn't work #671

Closed
2 of 9 tasks
ryenyuku opened this issue Mar 25, 2023 · 4 comments
Closed
2 of 9 tasks

Photon-styled navigation button doesn't work #671

ryenyuku opened this issue Mar 25, 2023 · 4 comments
Labels
Class::Layout-Others Layout issues except Padding and Size issues Component::Toolbar Toolbar or navbar Distribution::Photon-Style Photon style distribution related Env::Linux Issues on Linux Issue::Bug Something isn't working

Comments

@ryenyuku
Copy link
Contributor

ryenyuku commented Mar 25, 2023

Describe the bug

Applying userChrome.combined.nav_button along with userChrome.combined.sub_button.as_normal does not give the expected photon-ish navigation button appearance and instead will still combine the back and forward navigation button.

Expected behavior

Give the photon-ish navigation button just like in #511 at the "Photon with multirow" section.

Screenshots

No response

OS

Linux

OS - Others

No response

Firefox Version

111.0.1

Distribution

Theme

Theme - More Info

Matte Black Green

user.js setup

user.js setup
// == Theme Distribution Settings ==============================================
user_pref("userChrome.tab.connect_to_window",          true); // Original, Photon
user_pref("userChrome.tab.color_like_toolbar",         true); // Original, Photon

user_pref("userChrome.tab.lepton_like_padding",       false); // Original
user_pref("userChrome.tab.photon_like_padding",        true); // Photon

user_pref("userChrome.tab.dynamic_separator",         false); // Original, Proton
user_pref("userChrome.tab.static_separator",           true); // Photon
user_pref("userChrome.tab.static_separator.selected_accent", false); // Just option

user_pref("userChrome.tab.newtab_button_like_tab",    false); // Original
user_pref("userChrome.tab.newtab_button_smaller",      true); // Photon
user_pref("userChrome.tab.newtab_button_proton",      false); // Proton

user_pref("userChrome.icon.panel_full",               false); // Original, Proton
user_pref("userChrome.icon.panel_photon",              true); // Photon

// Original Only
user_pref("userChrome.tab.box_shadow",                false);
user_pref("userChrome.tab.bottom_rounded_corner",     false);

// Photon Only
user_pref("userChrome.tab.photon_like_contextline",    true);
user_pref("userChrome.rounding.square_tab",            true);

// == Theme Custom Settings ====================================================
// -- User Chrome --------------------------------------------------------------
user_pref("userChrome.decoration.panel_button_separator",   true);
user_pref("userChrome.decoration.panel_arrow",              true);

user_pref("userChrome.combined.nav_button",                 true);
user_pref("userChrome.combined.sub_button.as_normal",       true);

user_pref("userChrome.padding.urlView_expanding",           true);
user_pref("userChrome.padding.urlView_result",              true);
user_pref("userChrome.padding.toolbar_button.compact",      true);

user_pref("userChrome.urlView.always_show_page_actions",    true);
user_pref("userChrome.urlView.move_icon_to_left",           true);

user_pref("userChrome.rounding.square_panel",               true);
user_pref("userChrome.rounding.square_panelitem",           true);

user_pref("userChrome.panel.full_width_separator",          true);
user_pref("userChrome.panel.full_width_padding",            true);

Additional context

No response

@ryenyuku ryenyuku added the Issue::Bug Something isn't working label Mar 25, 2023
@ryenyuku
Copy link
Contributor Author

Looks like the culprit is in https://github.com/black7375/Firefox-UI-Fix/blob/master/css/leptonChrome.css#L8186 where an incorrect check is being done, and will only give the photon-ish nav button if userChrome.combined.urlbar.home_button is enabled too

@black7375 black7375 added Env::Linux Issues on Linux Component::Toolbar Toolbar or navbar Distribution::Photon-Style Photon style distribution related Class::Layout-Others Layout issues except Padding and Size issues labels Mar 27, 2023
@black7375
Copy link
Owner

Thank you for waiting. I just updated.

@black7375
Copy link
Owner

Try to use new version please!!

@ryenyuku
Copy link
Contributor Author

ryenyuku commented May 5, 2023

Try to use new version please!!

Yeah, the latest version fixed it. Thanks for the patch 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Class::Layout-Others Layout issues except Padding and Size issues Component::Toolbar Toolbar or navbar Distribution::Photon-Style Photon style distribution related Env::Linux Issues on Linux Issue::Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants