Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ver 6.0.0 Feedback Thread #438

Merged
merged 93 commits into from
Aug 23, 2022
Merged

Ver 6.0.0 Feedback Thread #438

merged 93 commits into from
Aug 23, 2022

Conversation

black7375
Copy link
Owner

@black7375 black7375 commented Jul 24, 2022

Describe the PR

As mentioned in #380 , It aim to provide a minimal UI.
Inspired by Mozilla Labs's Prospector: OneLiner(Blog), Prospector: LessChrome HD(Blog) projects and Microsoft Edge Vertical Tab.

  • One liner UI
    • userChrome.tabbar.one_liner
    • userChrome.tabbar.one_liner.combine_navbar
    • userChrome.tabbar.one_liner.tabbar_first
    • userChrome.tabbar.one_liner.responsive
  • Auto Hide UI
    • userChrome.autohide.tab
    • userChrome.autohide.tab.opacity
    • userChrome.autohide.tab.blur
    • userChrome.autohide.tabbar
    • userChrome.autohide.navbar
    • userChrome.autohide.bookmarkbar
    • userChrome.autohide.sidebar
    • userChrome.autohide.fill_urlbar
    • userChrome.autohide.back_button
    • userChrome.autohide.forward_button
    • userChrome.autohide.page_action
    • userChrome.autohide.toolbar_overlap
  • Hidden UI
    • userChrome.hidden.tab_icon
    • userChrome.hidden.tab_icon.always
    • userChrome.hidden.tabbar
    • userChrome.hidden.navbar
    • userChrome.hidden.sidebar_header
    • userChrome.hidden.sidebar_header.vertical_tab_only
    • userChrome.hidden.urlbar_iconbox
    • userChrome.hidden.bookmarkbar_icon
    • userChrome.hidden.bookmarkbar_label
    • userChrome.hidden.disabled_menu
    • userChrome.tabbar.on_bottom.hidden_single_tab
  • Monospace
    • userChrome.theme.monospace
    • userContent.page.monospace
  • Centered UI
    • userChrome.centered.tab
    • userChrome.centered.tab.label
    • userChrome.centered.urlbar
    • userChrome.centered.bookmarkbar
  • Vertical Tab support

It is not yet stabilized API, and there may be changes before merging.


Some API has been breaking change.

  • userChrome.tab.on_bottom -> userChrome.tabbar.on_bottom
  • userChrome.tab.on_bottom.above_bookmark -> userChrome.tabbar.on_bottom.above_bookmark
  • userChrome.tab.on_bottom.menubar_on_top -> userChrome.tabbar.on_bottom.menubar_on_top
  • userChrome.tab.centered_label -> userChrome.centered.tab.label

Setup - Please refer Wiki:Installation Guide

## First user ##################################################################
# At <FIREFOX_PROFILE_DIRECTORY>

# Original dev version
git clone https://github.com/black7375/Firefox-UI-Fix -b dev

# Photon style dev version
git clone https://github.com/black7375/Firefox-UI-Fix  chrome -b photon-style-dev

# Proton style dev version
git clone https://github.com/black7375/Firefox-UI-Fix chrome -b proton-style-dev

## Existing user ###############################################################
# At <FIREFOX_PROFILE_DIRECTORY>/chrome

# Original dev version
git checkout dev
git pull

# Proton style dev version
git checkout photon-style-dev
git pull

# Proton style dev version
git checkout proton-style-dev
git pull

Related Issue

Screenshots

I'd like to show you some use cases.

  • Oneliner + Tabs on bottom
    • userChrome.tabbar.one_liner
    • userChrome.tabbar.one_liner.responsive
    • userChrome.tabbar.on_bottom
firefox-responsive-ui.mp4
  • Oneliner + Centered
    • userChrome.tabbar.one_liner
    • userChrome.tabbar.one_liner.combine_navbar
    • userChrome.autohide.forward_button
    • userChrome.centered.tab
    • userChrome.centered.tab.label
    • userChrome.centered.bookmarkbar

image

  • Autohide navbar + Centered
    • userChrome.autohide.tab
    • userChrome.autohide.tab.blur
    • userChrome.autohide.navbar
    • userChrome.centered.tab
    • userChrome.centered.tab.label
    • userChrome.centered.bookmarkbar

image

  • Vertical Tab
    • userChrome.tabbar.as_titlebar
    • userChrome.centered.tab
    • userChrome.autohide.sidebar
    • userChrome.sidebar.overlap
    • userChrome.hidden.sidebar_header
    • userChrome.hidden.sidebar_header.vertical_tab_only

image

Additional context

You can suggest compatibility issues, option names, etc.

Always include `padding-inline-end` at label self.
It's prevent recalculation.
- Tree Style Tab
- Tab Center Reborn
@black7375
Copy link
Owner Author

LGTM
I will try to add it as an option tomorrow.

@black7375
Copy link
Owner Author

I checked and the feature works limited.
It can't adjust the size of the tab layout without sacrificing the title menu bar or other compatibility.

An alternative that does not sacrifice compatibility is that navbar works with overlap mode.

Overlap.Fill.URL.bar.mp4

@Zabooby
Copy link

Zabooby commented Aug 11, 2022

Hm I think the one i linked looks smoother, would it be possible to just copy it over and just try and make the url bar as small as possible?

Another way you could hide it is like this, I guess that wouldn't be a oneliner though.

Also I remember there being some css stuff here related to the url bar that might help.

@black7375
Copy link
Owner Author

black7375 commented Aug 11, 2022

Autohide like slickfox are already fully supported.

firefox-autohide-navbar.mp4
  • userChrome.autohide.navbar
  • userChrome.autohide.toolbar_overlap

The problem is that the layout adjustment of the Tab Bar is not possible without sacrificing compatibility only if it is a hover of Nav Bar.
If you use FewerFox's implementation, there are many problems.

FewerFox.mp4
  • URL Bar is truncated if density or number of buttons are different
  • The size is strange when there is a bookmark bar
  • The position of the title menu bar is strange

@Zabooby
Copy link

Zabooby commented Aug 11, 2022

I see, would you be able to fix those issues and is it even possible to get the url bar to auto hide the way I described it without any problems?

And will version 6 have 2 possible onliners the slickfox version and something like cascade ?

@black7375
Copy link
Owner Author

Yes, See Oneliner + Centered , Autohide navbar + Centered screenshots.

@black7375 black7375 merged commit 1a4206f into master Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue::Enhancement New feature or request Priority::High Solve and focus on it first
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants