Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rounding for dialogs & firefox view #661

Merged
merged 2 commits into from Mar 10, 2023
Merged

Fix rounding for dialogs & firefox view #661

merged 2 commits into from Mar 10, 2023

Conversation

ricewind012
Copy link
Contributor

Describe the PR
Dialogs' matching now uses regex in case there may be more of them in the future

PR Type

  • Add: Add feature or enhanced.
  • Fix: Bug fix or change default values.
  • Clean: Refactoring.
  • Doc: Update docs.

Related Issue
#645, #649

black7375
black7375 approved these changes Mar 10, 2023
View reviewed changes
Copy link
Owner

@black7375 black7375 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@black7375 black7375 merged commit 267c31c into black7375:master Mar 10, 2023
@ricewind012 ricewind012 deleted the patch-1 branch March 10, 2023 20:29
@black7375 black7375 added Component::UserContents Page related issues except Activity-Stream, not browser UI Compenent::Others Other components.. Class::Rounding Element's rounding labels Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@black7375 black7375 black7375 approved these changes

Assignees
No one assigned
Labels
Class::Rounding Element's rounding Compenent::Others Other components.. Component::UserContents Page related issues except Activity-Stream, not browser UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ricewind012 @black7375