feat: add click_and_drag option #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blackary
approved these changes
Jun 4, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the request from #9 while I'm at it.
Doesn't send the onmousedown event right away (or any onmousemove events) because that would cause streamlit to refresh and potentially cause jitter and such.
Because of this you won't be able to e.g. draw a box around what the user is selecting until they've actually moused up, but it's a start at least. Could in theory implement an option to display a box over what the user is dragging with javascript, but that was more than I had time to implement at the moment.
Should again be backwards compatible as the original onclick function behaves the same, to get the new behaviour you have to opt in with
click_and_drag=True.