This repository has been archived by the owner on Dec 8, 2022. It is now read-only.
Add better type info and documentation to SkyPactService. #430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #430 +/- ##
=======================================
Coverage 99.31% 99.31%
=======================================
Files 73 73
Lines 1904 1904
Branches 297 297
=======================================
Hits 1891 1891
Misses 13 13
Continue to review full report at Codecov.
|
Blackbaud-BobbyEarl
approved these changes
Jul 3, 2018
Blackbaud-MikitaYankouski
pushed a commit
to Blackbaud-MikitaYankouski/skyux-builder
that referenced
this pull request
May 3, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on pact tests for my SPA, it was confusing/misleading to work with the SkyPactService class since it did not accurately represent the parameters and return types of it's functions. Since this is just a wrapper class around pact-js, I've added the missing type info and method descriptions based on the official pact-js site. This should help developers writing pact tests in their SPAs.