Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

Update version of @skyux/i18n #476

Merged
merged 2 commits into from
Sep 24, 2018
Merged

Update version of @skyux/i18n #476

merged 2 commits into from
Sep 24, 2018

Conversation

Blackbaud-SteveBrush
Copy link
Member

@Blackbaud-SteveBrush Blackbaud-SteveBrush commented Sep 24, 2018

@Blackbaud-BobbyEarl I reverted some changes I made to the sky-pages-module-generator. I've tested this branch on skyux2 and a few internal SPAs.

This solves two problems:

  1. Fixes the No provider for SkyAuthHttp! error.
  2. I've updated @skyux/i18n to fix another problem that only occurred during unit tests. See: Fixed linting errors skyux-i18n#11

@codecov-io
Copy link

codecov-io commented Sep 24, 2018

Codecov Report

Merging #476 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #476   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          53     53           
  Lines        1637   1642    +5     
  Branches      241    241           
=====================================
+ Hits         1637   1642    +5
Flag Coverage Δ
#builder 100% <100%> (ø) ⬆️
#runtime 100% <ø> (ø) ⬆️
#srcapp 100% <ø> (ø) ⬆️
Impacted Files Coverage Δ
lib/sky-pages-module-generator.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 164e336...6552fcb. Read the comment docs.

@Blackbaud-SteveBrush Blackbaud-SteveBrush merged commit 2c02329 into master Sep 24, 2018
@Blackbaud-SteveBrush Blackbaud-SteveBrush deleted the update-i18n branch September 24, 2018 20:15
Blackbaud-MikitaYankouski pushed a commit to Blackbaud-MikitaYankouski/skyux-builder that referenced this pull request May 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants