Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

Replaced SKY UX error component with iframe #485

Merged
merged 2 commits into from
Oct 24, 2018
Merged

Conversation

Blackbaud-SteveBrush
Copy link
Member

This was already done for RC: https://github.com/blackbaud/skyux-builder/pull/436/files

Think we could minimize the changes in RC by merging this into master?

@codecov-io
Copy link

codecov-io commented Oct 10, 2018

Codecov Report

Merging #485 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #485   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          54     54           
  Lines        1680   1682    +2     
  Branches      250    250           
=====================================
+ Hits         1680   1682    +2
Flag Coverage Δ
#builder 100% <100%> (ø) ⬆️
#runtime 100% <ø> (ø) ⬆️
#srcapp 100% <ø> (ø) ⬆️
Impacted Files Coverage Δ
lib/sky-pages-route-generator.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c11ebf...22da0e9. Read the comment docs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants