This repository has been archived by the owner on Dec 8, 2022. It is now read-only.
[rc] Add type for errorType
#118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## rc-4.0.0 #118 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 26 26
Lines 911 911
Branches 127 127
==========================================
Hits 911 911 Continue to review full report at Codecov.
|
|
Preview build at https://host.nxt.blackbaud.com/skyux-forms?_sp.spa=pr-rc-error-type |
| /** | ||
| * Specifies the type of error that was thrown. | ||
| */ | ||
| export type SkyFileItemErrorType = 'fileType' | 'minFileSize' | 'maxFileSize' | 'validate'; |
There was a problem hiding this comment.
If consumers need this type, shouldn't we be exporting it in the public_api.ts file?
Blackbaud-AlexKingman
approved these changes
May 12, 2020
Blackbaud-SteveBrush
added a commit
that referenced
this pull request
May 13, 2020
* [rc] Angular 9; drop RxJS 5 (#102) * Updated changelog/package.json for 4.0.0-rc.0 release * [rc] Merge master; test fixtures (#115) * Bump acorn from 6.4.0 to 6.4.1 (#110) Bumps [acorn](https://github.com/acornjs/acorn) from 6.4.0 to 6.4.1. - [Release notes](https://github.com/acornjs/acorn/releases) - [Commits](acornjs/acorn@6.4.0...6.4.1) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * added license (#112) Added license to address blackbaud/skyux2-docs#894 * Toggle Switch - Phase 2 docs (#109) * First pass of adding phase 2 of toggle switch docs * Added docs tools styles & related components * Add design demo * Clean up code for e2e check * Remove unused imports * Add code demo * Update the pact package * Fix visual * Implemented feedback * Fixed formatting issues * updated dev dependencies * Fix demo * Add default value for `checked` * Added description for toggle switch label * Added description for SkyToggleSwitchChange * Updating with revised text Co-authored-by: Somalia Jamall <somalia.jamall@blackbaud.com> Co-authored-by: John Lyons <John.Lyons@blackbaud.com> Co-authored-by: Blackbaud-SteveBrush <steve.brush@blackbaud.com> * A11y improvements (#114) * a11y improvements * Remove codeowners * Upgrade packages * Fix screenshots * Fix visual * Revert image deletion Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Denise Pena <Denise.Pena@blackbaud.me> Co-authored-by: Somalia Jamall <somalia.jamall@blackbaud.com> Co-authored-by: John Lyons <John.Lyons@blackbaud.com> * Updated changelog/package.json for 4.0.0-rc.1 release * [rc] Added type for `errorType` (#118) * Upgrade * Update changelog/package.json for 4.0.0 release * Updated changelog * Fix changelog * Update date and wording tweak Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Denise Pena <Denise.Pena@blackbaud.me> Co-authored-by: Somalia Jamall <somalia.jamall@blackbaud.com> Co-authored-by: John Lyons <John.Lyons@blackbaud.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: https://github.com/blackbaud/skyux-forms/issues/103