Implemented event listener for when the link input is blurred in the file drop component. #122
Conversation
…file drop component.
Codecov Report
@@ Coverage Diff @@
## master #122 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 29 29
Lines 944 951 +7
Branches 127 127
=========================================
+ Hits 944 951 +7
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Just a couple small comments. Also a question - the original issue was to tell if the form is dirty. This only provides a blur event. They can, of course, check the values to see if the form is truly dirty once the blur event happens. Did we check with the consumer to make sure this is what they expect? (I know this particular component is a little different than our normal form controls, so I'm assuming there's an exception here)
src/app/public/modules/file-attachment/file-drop.component.html
Outdated
Show resolved
Hide resolved
|
@Blackbaud-AlexKingman due to the fact that the items and uploads are handled in two different components it is not possible to make this a control value accessor and thus have this component update the form's states directly. The issue that consumer was having was that due to us having the access to the link input they could not tell whether or not they should mark their outer form dirty. Our initial stab at this issue was to add that wrapping component that would be able to be a control value accessor and would handle all the form stuff for the consumer but because of design restrictions with the metadata on the item components that was not possible to do. This change gives the consumer the ability to know when a user has touched the input field and thus will allow them to handle their forms dirty state directly. If there was a way that we could do it for them that would be great but unfortunately it isn't possible with how this component is currently designed and constructed. |
…o link-input-blur-event
#104