This repository has been archived by the owner on Dec 8, 2022. It is now read-only.
Fix the aria-label property from showing up when there isn't one #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blackbaud-TrevorBurch
requested review from
Blackbaud-AlexKingman and
Blackbaud-SteveBrush
as code owners
Codecov Report
@@ Coverage Diff @@
## master #14 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 13 13
Lines 515 515
Branches 87 87
=====================================
Hits 515 515
Continue to review full report at Codecov.
|
Blackbaud-SteveBrush
approved these changes
Jan 10, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because this property was being set to an empty string the attribute was showing up in the HTML with no value. Removing this default will ensure that the attribute only shows up if it is set by a consumer.