Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

Selection box component #232

Merged
merged 36 commits into from
Mar 19, 2021

Conversation

Blackbaud-AlexKingman
Copy link
Contributor

@Blackbaud-AlexKingman Blackbaud-AlexKingman commented Jan 28, 2021

No description provided.

Copy link
Member

@Blackbaud-SteveBrush Blackbaud-SteveBrush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, everything appears to be on the right track. Happy to talk more about it over the phone if needed.

@blackbaud-ado
Copy link
Member

@blackbaud-ado
Copy link
Member

@codecov
Copy link

codecov bot commented Feb 2, 2021

Codecov Report

Merging #232 (ae182fa) into master (07014e9) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            master      #232    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           29        36     +7     
  Lines          881      1030   +149     
  Branches       168       196    +28     
==========================================
+ Hits           881      1030   +149     
Impacted Files Coverage Δ
.../app/public/modules/checkbox/checkbox.component.ts 100.00% <100.00%> (ø)
src/app/public/modules/radio/radio.component.ts 100.00% <100.00%> (ø)
...les/selection-box/selection-box-adapter.service.ts 100.00% <100.00%> (ø)
...lection-box/selection-box-description.component.ts 100.00% <100.00%> (ø)
...ules/selection-box/selection-box-grid.component.ts 100.00% <100.00%> (ø)
...es/selection-box/selection-box-header.component.ts 100.00% <100.00%> (ø)
...c/modules/selection-box/selection-box.component.ts 100.00% <100.00%> (ø)
...blic/modules/selection-box/selection-box.module.ts 100.00% <100.00%> (ø)
...ection-box/types/selection-box-grid-align-items.ts 100.00% <100.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07014e9...ae182fa. Read the comment docs.

@blackbaud-ado
Copy link
Member

@blackbaud-ado
Copy link
Member

@Blackbaud-AlexKingman Blackbaud-AlexKingman marked this pull request as ready for review March 11, 2021 17:13
@blackbaud-ado
Copy link
Member

@blackbaud-ado
Copy link
Member

@blackbaud-ado
Copy link
Member

Copy link
Member

@Blackbaud-SteveBrush Blackbaud-SteveBrush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking really good!

@blackbaud-ado
Copy link
Member

@blackbaud-ado
Copy link
Member

Copy link
Contributor

@blackbaud-johnly blackbaud-johnly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor docs suggestions. All minor tweaks that can be handled later when we add the Design guidelines if it's not convenient to make changes now.

Co-authored-by: John Lyons <John.Lyons@blackbaud.com>
@blackbaud-ado
Copy link
Member

@Blackbaud-AlexKingman Blackbaud-AlexKingman merged commit 53d3967 into master Mar 19, 2021
@Blackbaud-AlexKingman Blackbaud-AlexKingman deleted the selection-box-consumer-supplies-control branch March 19, 2021 14:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
5 participants