-
Notifications
You must be signed in to change notification settings - Fork 4
Selection box component #232
Selection box component #232
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, everything appears to be on the right track. Happy to talk more about it over the phone if needed.
src/app/public/modules/selection-box/selection-box.component.html
Outdated
Show resolved
Hide resolved
src/app/public/modules/selection-box/selection-box.component.html
Outdated
Show resolved
Hide resolved
src/app/public/modules/selection-box/selection-box.component.html
Outdated
Show resolved
Hide resolved
src/app/public/modules/selection-box/selection-box-container.component.ts
Outdated
Show resolved
Hide resolved
src/app/visual/selection-box/selection-box-visual.component.html
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #232 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 29 36 +7
Lines 881 1030 +149
Branches 168 196 +28
==========================================
+ Hits 881 1030 +149
Continue to review full report at Codecov.
|
…hub.com/blackbaud/skyux-forms into selection-box-consumer-supplies-control
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking really good!
src/app/public/modules/selection-box/selection-box-grid.component.html
Outdated
Show resolved
Hide resolved
src/app/public/modules/selection-box/selection-box-grid.component.spec.ts
Outdated
Show resolved
Hide resolved
src/app/public/modules/selection-box/selection-box-grid.component.ts
Outdated
Show resolved
Hide resolved
src/app/public/modules/selection-box/selection-box-grid.component.ts
Outdated
Show resolved
Hide resolved
src/app/public/modules/selection-box/selection-box.component.scss
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor docs suggestions. All minor tweaks that can be handled later when we add the Design guidelines if it's not convenient to make changes now.
src/app/public/modules/selection-box/selection-box-adapter.service.ts
Outdated
Show resolved
Hide resolved
src/app/public/modules/selection-box/selection-box-adapter.service.ts
Outdated
Show resolved
Hide resolved
src/app/public/modules/selection-box/selection-box-adapter.service.ts
Outdated
Show resolved
Hide resolved
src/app/public/modules/selection-box/types/selection-box-grid-align-items.ts
Outdated
Show resolved
Hide resolved
src/app/public/modules/selection-box/types/selection-box-grid-align-items.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: John Lyons <John.Lyons@blackbaud.com>
ae182fa
No description provided.