Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

Replace theme conditionals in templates with new skyThemeIf directive #240

Merged
merged 16 commits into from
Mar 31, 2021

Conversation

johnhwhite
Copy link
Member

  • Replace theme conditionals in templates with new skyIfTheme directive
  • Remove SkyThemeService that is no longer needed

@blackbaud-ado
Copy link
Member

@blackbaud-ado
Copy link
Member

@blackbaud-ado
Copy link
Member

@blackbaud-ado
Copy link
Member

@blackbaud-ado
Copy link
Member

@codecov
Copy link

codecov bot commented Mar 22, 2021

Codecov Report

Merging #240 (e84e5bb) into master (f488925) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #240   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           36        36           
  Lines         1030      1029    -1     
  Branches       191       190    -1     
=========================================
- Hits          1030      1029    -1     
Impacted Files Coverage Δ
...modules/file-attachment/file-attachments.module.ts 100.00% <ø> (ø)
...pp/public/modules/input-box/input-box.component.ts 100.00% <ø> (ø)
...c/app/public/modules/input-box/input-box.module.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f488925...e84e5bb. Read the comment docs.

@blackbaud-ado
Copy link
Member

@blackbaud-ado
Copy link
Member

Copy link
Contributor

@Blackbaud-AlexKingman Blackbaud-AlexKingman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question. Looks good!

src/app/public/modules/input-box/input-box.module.ts Outdated Show resolved Hide resolved
@blackbaud-ado
Copy link
Member

@blackbaud-ado
Copy link
Member

@johnhwhite johnhwhite merged commit 30e9198 into master Mar 31, 2021
@johnhwhite johnhwhite deleted the replace-conditionals-with-skyiftheme branch March 31, 2021 17:10
@johnhwhite johnhwhite changed the title Replace theme conditionals in templates with new skyIfTheme directive Replace theme conditionals in templates with new skyThemeIf directive Mar 31, 2021
@johnhwhite johnhwhite mentioned this pull request Mar 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants