Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

Mark the radio group touched after losing focus from any input #257

Merged
merged 6 commits into from
Apr 15, 2021

Conversation

johnhwhite
Copy link
Member

No description provided.

@johnhwhite johnhwhite self-assigned this Apr 14, 2021
@blackbaud-ado
Copy link
Member

@blackbaud-ado
Copy link
Member

@blackbaud-ado
Copy link
Member

@codecov
Copy link

codecov bot commented Apr 15, 2021

Codecov Report

Merging #257 (bfce759) into master (901812f) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #257   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           36        36           
  Lines         1054      1060    +6     
  Branches       202       202           
=========================================
+ Hits          1054      1060    +6     
Impacted Files Coverage Δ
.../app/public/modules/radio/radio-group.component.ts 100.00% <100.00%> (ø)
src/app/public/modules/radio/radio.component.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 901812f...bfce759. Read the comment docs.

@johnhwhite johnhwhite marked this pull request as ready for review April 15, 2021 12:35
@blackbaud-ado
Copy link
Member

/**
* Fires when users focus off a radio button.
*/
public get blur(): Observable<undefined> {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would just make this a public property, instead of masking the EventEmitter with an Observable getter.

/**
 * @internal
 */
public blur = new Subject<void>();

@blackbaud-ado
Copy link
Member

@johnhwhite johnhwhite merged commit 28eec10 into master Apr 15, 2021
@johnhwhite johnhwhite deleted the radio-group-mark-touched-after-blur branch April 15, 2021 20:23
@johnhwhite johnhwhite mentioned this pull request Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants