This repository has been archived by the owner on Dec 8, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 4
Mark the radio group touched after losing focus from any input #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #257 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 36 36
Lines 1054 1060 +6
Branches 202 202
=========================================
+ Hits 1054 1060 +6
Continue to review full report at Codecov.
|
johnhwhite
requested review from
Blackbaud-TrevorBurch and
Blackbaud-SteveBrush
and removed request for
Blackbaud-TrevorBurch
April 15, 2021 12:35
/** | ||
* Fires when users focus off a radio button. | ||
*/ | ||
public get blur(): Observable<undefined> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would just make this a public property, instead of masking the EventEmitter
with an Observable
getter.
/**
* @internal
*/
public blur = new Subject<void>();
Blackbaud-SteveBrush
approved these changes
Apr 15, 2021
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.