You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@Blackbaud-AlexKingman - the only question I would have (maybe for @Blackbaud-AdamFunderburk) is whether or not clicking on the icon should focus the main section of the input box? Currently nothing happens other than a border flash and the mouse icon when you hover over the icon changes to the standard icon instead of the text cursor that is displayed elsewhere on the input box.
@Blackbaud-AlexKingman - the only question I would have (maybe for @Blackbaud-AdamFunderburk) is whether or not clicking on the icon should focus the main section of the input box? Currently nothing happens other than a border flash and the mouse icon when you hover over the icon changes to the standard icon instead of the text cursor that is displayed elsewhere on the input box.
Yes, it would be correct to focus the input box if the user clicks the icon.
Do we anticipate that there will ever be a scenario where we have inset buttons and an inset icon? We currently do not have a visual example or test of this scenario. Should we?
I'd love for @Blackbaud-AdamFunderburk to just double check the mouse icon when hovering over the icon? We now populate the focus back to the input but the mouse icon changes to a standard pointer when you hover the icon instead of the text cursor that is there on the rest of the input box. For a button this would make sense but I'd like him to verify here where the icon is mostly just visual.
Do we anticipate that there will ever be a scenario where we have inset buttons and an inset icon? We currently do not have a visual example or test of this scenario. Should we?
I'd love for @Blackbaud-AdamFunderburk to just double check the mouse icon when hovering over the icon? We now populate the focus back to the input but the mouse icon changes to a standard pointer when you hover the icon instead of the text cursor that is there on the rest of the input box. For a button this would make sense but I'd like him to verify here where the icon is mostly just visual.
I can't think of any scenarios right now, and I can't think of a reason to make an example without a scenario.
The cursor behavior is probably fine, as long as the focus gets into the field.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.