Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

Fix radio to support boolean values #31

Merged
merged 2 commits into from
Mar 27, 2019
Merged

Conversation

Blackbaud-SteveBrush
Copy link
Member

CHANGELOG.md Outdated
@@ -1,3 +1,7 @@
# 3.1.1 (2019-03-27)

- Fixed radio group component to support boolean values. [#30](https://github.com/blackbaud/skyux-forms/pull/30)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this link to itself? #31

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep! I was trying to make a guess for the correct number before the PR was created. Thanks.

Copy link
Contributor

@Blackbaud-AlexKingman Blackbaud-AlexKingman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Mar 27, 2019

Codecov Report

Merging #31 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #31   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          13     13           
  Lines         527    529    +2     
  Branches       87     89    +2     
=====================================
+ Hits          527    529    +2
Impacted Files Coverage Δ
.../app/public/modules/radio/radio-group.component.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6019dd1...41f7478. Read the comment docs.

@Blackbaud-SteveBrush Blackbaud-SteveBrush merged commit ac969ad into master Mar 27, 2019
@Blackbaud-SteveBrush Blackbaud-SteveBrush deleted the fix-radio-booleans branch March 27, 2019 20:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants