Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

Adopt SkyLibResourcesProvider #5

Merged
merged 1 commit into from
Oct 18, 2018
Merged

Conversation

Blackbaud-SteveBrush
Copy link
Member

No description provided.

@codecov-io
Copy link

Codecov Report

Merging #5 into master will decrease coverage by 0.19%.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master      #5     +/-   ##
========================================
- Coverage     100%   99.8%   -0.2%     
========================================
  Files          11      13      +2     
  Lines         499     515     +16     
  Branches       85      88      +3     
========================================
+ Hits          499     514     +15     
- Misses          0       1      +1
Impacted Files Coverage Δ
...ublic/plugin-resources/forms-resources-provider.ts 90.9% <100%> (ø)
...pp/public/modules/shared/forms-resources.module.ts 100% <100%> (ø)
...p/public/modules/file-attachment/file-size.pipe.ts 100% <100%> (ø) ⬆️
...modules/file-attachment/file-attachments.module.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8cee116...da82ad9. Read the comment docs.

Copy link
Contributor

@blackbaud-conorwright blackbaud-conorwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

"@skyux/indicators": ">=3.0.0-rc.0",
"rxjs": "^5.4.3"
"@skyux/i18n": "^3.2.0",
"@skyux/indicators": "^3.0.0-rc.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait I missed this one, it should be on rc.2

@Blackbaud-SteveBrush Blackbaud-SteveBrush merged commit 81812fe into master Oct 18, 2018
@Blackbaud-SteveBrush Blackbaud-SteveBrush deleted the lib-resources branch October 18, 2018 14:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants