This repository has been archived by the owner on Dec 8, 2022. It is now read-only.
[rc] merge from master #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added license to address blackbaud/skyux2-docs#894
* removed moment * removed moment * unnecessary commit * Fix unit test to actually fail * fixed test * destroy fixture after each * isolated logic to make it easier to test * removed unused imports * removed to throw Co-authored-by: Alex Kingman <alex.kingman@blackbaud.me> Co-authored-by: Blackbaud-SteveBrush <steve.brush@blackbaud.com>
Co-authored-by: Alex Kingman <alex.kingman@blackbaud.me>
Blackbaud-AlexKingman
requested a review
from Blackbaud-SteveBrush
as a code owner
| @@ -72,6 +95,6 @@ export class SkyLinkRecordsItemDiffComponent implements OnInit { | |||
| selected: selected[f.key] || false | |||
| }; | |||
| }); | |||
| }); | |||
| }]); | |||
There was a problem hiding this comment.
☝️ to avoid deprecation warnings around combineLatest.
added 2 commits
May 6, 2020 14:42
Codecov Report
@@ Coverage Diff @@
## rc-4.0.0 #20 +/- ##
=============================================
+ Coverage 99.81% 100.00% +0.18%
=============================================
Files 36 36
Lines 536 534 -2
Branches 85 85
=============================================
- Hits 535 534 -1
+ Misses 1 0 -1
Continue to review full report at Codecov.
|
Blackbaud-SteveBrush
approved these changes
May 6, 2020
Blackbaud-SteveBrush
added a commit
that referenced
this pull request
May 22, 2020
* [rc] Initial commit (#16) * Updated changelog/package.json for 4.0.0-rc.0 release * [rc] merge from master (#20) * Adding license (#17) Added license to address blackbaud/skyux2-docs#894 * removed moment (#18) * removed moment * removed moment * unnecessary commit * Fix unit test to actually fail * fixed test * destroy fixture after each * isolated logic to make it easier to test * removed unused imports * removed to throw Co-authored-by: Alex Kingman <alex.kingman@blackbaud.me> Co-authored-by: Blackbaud-SteveBrush <steve.brush@blackbaud.com> * 3.2.1 relelase (#19) Co-authored-by: Alex Kingman <alex.kingman@blackbaud.me> * removed merge conflicts * removed accidental package * upgraded deps, removed index.ts files, minor code style updates * fixed tests * style fix Co-authored-by: Denise Pena <Denise.Pena@blackbaud.me> Co-authored-by: Alex Kingman <alex.kingman@blackbaud.me> Co-authored-by: Blackbaud-SteveBrush <steve.brush@blackbaud.com> * Updated changelog/package.json for 4.0.0-rc.1 release * Upgrade deps * PR feedback * Add Angular 9 entry under RC Co-authored-by: Alex <alex.kingman@blackbaud.com> Co-authored-by: Denise Pena <Denise.Pena@blackbaud.me> Co-authored-by: Alex Kingman <alex.kingman@blackbaud.me> Co-authored-by: John Lyons <John.Lyons@blackbaud.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.