Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

[rc] Add test fixtures #68

Merged
merged 3 commits into from
Apr 30, 2020
Merged

Conversation

Blackbaud-SteveBrush
Copy link
Member

@Blackbaud-SteveBrush Blackbaud-SteveBrush commented Apr 29, 2020

@codecov
Copy link

codecov bot commented Apr 29, 2020

Codecov Report

Merging #68 into rc-4.0.0 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           rc-4.0.0       #68   +/-   ##
==========================================
  Coverage    100.00%   100.00%           
==========================================
  Files            17        17           
  Lines           382       382           
  Branches         39        39           
==========================================
  Hits            382       382           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4bb60b...d3b0838. Read the comment docs.

@Blackbaud-SteveBrush Blackbaud-SteveBrush marked this pull request as ready for review April 30, 2020 16:03
Copy link
Contributor

@Blackbaud-AlexKingman Blackbaud-AlexKingman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One style comment.

return this.debugEl.queryAll(By.css('.sky-grid-row'));
}

private getRowEl(index: number) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Method needs a return type.

@Blackbaud-SteveBrush Blackbaud-SteveBrush merged commit 2e79582 into rc-4.0.0 Apr 30, 2020
@Blackbaud-SteveBrush Blackbaud-SteveBrush deleted the rc-add-test-fixture branch April 30, 2020 18:27
Blackbaud-SteveBrush added a commit that referenced this pull request May 15, 2020
* [rc] Initial commit (#65)

* Initial commit

* Add travis

* Updated changelog/package.json for 4.0.0-rc.0 release

* [rc] Added test fixtures (#68)

* Updated changelog/package.json for 4.0.0-rc.1 release

* [rc] merge from master (#73)

* Adding license (#66)

Added license to address blackbaud/skyux2-docs#894

* Removed `moment` (#69)

* removed moment

* package update

* removed comma

Co-authored-by: Alex Kingman <alex.kingman@blackbaud.me>

* 3.6.3 release (#70)

Co-authored-by: Alex Kingman <alex.kingman@blackbaud.me>

* Update to column selector index to go along with list builder changes (#67)

Co-authored-by: Alex <alex.kingman@blackbaud.com>

* Release 3.6.4 (#71)

* Updated changelog and package.json for 3.6.4 release

* Wording tweak

* skyux migrate

Co-authored-by: Denise Pena <Denise.Pena@blackbaud.me>
Co-authored-by: Alex Kingman <alex.kingman@blackbaud.me>
Co-authored-by: Trevor Burch <Trevor.Burch@blackbaud.com>

* Updated changelog/package.json for 4.0.0-rc.2 release

* Upgrade deps

* Update changelog/package.json for 4.0.0 release

* Fix test

* Remove screenshots

* Wording edits

Co-authored-by: Alex <alex.kingman@blackbaud.com>
Co-authored-by: Denise Pena <Denise.Pena@blackbaud.me>
Co-authored-by: Alex Kingman <alex.kingman@blackbaud.me>
Co-authored-by: Trevor Burch <Trevor.Burch@blackbaud.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants