docs: add lookup cell type's JSDocs & add lookup code examples to code-examples SPA #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI ran the following commands for commit 8595f87. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
Blackbaud-TrevorBurch
requested changes
Mar 10, 2022
There was a problem hiding this comment.
@bradenbiz - just a couple things.
Also, your PR title needs to match our new format and you appear to have a build issue.
libs/components/ag-grid/src/lib/modules/ag-grid/types/cell-type.ts
Outdated
Show resolved
Hide resolved
apps/code-examples/src/app/code-examples/lookup/lookup/async/lookup-async-demo.component.ts
Outdated
Show resolved
Hide resolved
johnhwhite
requested changes
Mar 10, 2022
libs/components/ag-grid/src/lib/modules/ag-grid/types/cell-type.ts
Outdated
Show resolved
Hide resolved
apps/code-examples/src/app/code-examples/lookup/lookup/async/lookup-async-demo.component.ts
Outdated
Show resolved
Hide resolved
bradenbiz
changed the title
bradenbiz
changed the title
bradenbiz
requested review from
Blackbaud-TrevorBurch,
johnhwhite and
blackbaud-johnly
bradenbiz
force-pushed
the
add-lookup-cell-jsdocs
branch
from
8dc8dad
to
e296d9f
Compare
bradenbiz
force-pushed
the
add-lookup-cell-jsdocs
branch
from
c1be7dc
to
8595f87
Compare
bradenbiz
changed the title
johnhwhite
approved these changes
Mar 11, 2022
Blackbaud-TrevorBurch
approved these changes
Mar 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.