feat(components/forms): change SkyCheckboxChange type to an interface
#597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Component Storybooks: Apps: |
libs/components/forms/src/lib/modules/checkbox/checkbox.component.ts
Outdated
Show resolved
Hide resolved
...rc/lib/modules/list-view-checklist/fixtures/list-view-checklist-toolbar.component.fixture.ts
Outdated
Show resolved
Hide resolved
libs/components/forms/src/lib/modules/checkbox/checkbox-change.ts
Outdated
Show resolved
Hide resolved
Blackbaud-ErikaMcVey
force-pushed
the
checkbox-change-interface
branch
from
6542564
to
1db855b
Compare
...rc/lib/modules/list-view-checklist/fixtures/list-view-checklist-toolbar.component.fixture.ts
Outdated
Show resolved
Hide resolved
Blackbaud-ErikaMcVey
force-pushed
the
checkbox-change-interface
branch
from
1db855b
to
97721d2
Compare
Blackbaud-PaulCrowder
previously approved these changes
Sep 30, 2022
change the `SkyCheckboxChange` type from a class to an interface BREAKING CHANGE: This change updates the `SkyCheckboxChange` type to be an interface instead of a class. To address this, remove any instances of instantiating the `SkyCheckboxChange` class and instead create an object that uses the interface type.
Blackbaud-ErikaMcVey
force-pushed
the
checkbox-change-interface
branch
from
97721d2
to
e4f824f
Compare
Blackbaud-PaulCrowder
approved these changes
Oct 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: This change updates the
SkyCheckboxChangetype to be an interface instead of a class. To address this, remove any instances of instantiating theSkyCheckboxChangeclass and instead create an object that uses the interface type.