Skip to content
This repository has been archived by the owner on Jun 22, 2023. It is now read-only.
This repository has been archived by the owner on Jun 22, 2023. It is now read-only.

Installation instructions for @skyux/datetime don't mention peer dependencies #518

Closed
thatoddmailbox opened this issue Jun 11, 2019 · 2 comments

Comments

@thatoddmailbox
Copy link

The installation instructions for the Datepicker component give the single command npm install @skyux/datetime --save --save-exact. However, this doesn't install the required peer dependency @skyux/popovers, and the Installation section on that page does not mention anything about that dependency, saying that you only have to run that command and add the export to your app-sky.module.ts. (though the broader "Use SKY UX Modules" instructions do mention watching out for peer dependency warnings)

@blackbaud-johnly
Copy link
Contributor

Thanks, @thatoddmailbox. I am about to start work on updating the design/organization of Installation sections for all the component docs and am planning on calling out the need to watch for peer dependencies. I'll keep the issue you've filed in mind as I work on that docs update.

@Blackbaud-DeniseCisneros
Copy link
Contributor

Addressed in #569

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants