Skip to content
This repository has been archived by the owner on Mar 10, 2020. It is now read-only.

bugfix to use stachelink properly #452

Merged
merged 2 commits into from
Apr 26, 2018
Merged

Conversation

Blackbaud-BrandonJones
Copy link
Contributor

https://github.com/blackbaud/stache2/issues/449
Solved 2 problems:

The router would not navigate to a fragment on another page if the fragment also existed on the current page.

The router would not navigate on the current page if the path was . with a fragment.

@codecov-io
Copy link

Codecov Report

Merging #452 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #452   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          82     82           
  Lines        1075   1077    +2     
  Branches      132    132           
=====================================
+ Hits         1075   1077    +2
Impacted Files Coverage Δ
src/app/public/src/modules/nav/nav.service.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d63e0c8...b03ccf5. Read the comment docs.

Copy link
Contributor

@blackbaud-brandonhare blackbaud-brandonhare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice work!

@Blackbaud-BrandonJones Blackbaud-BrandonJones merged commit e4fb45b into master Apr 26, 2018
@Blackbaud-BrandonJones Blackbaud-BrandonJones deleted the bugfix-stache-link branch April 26, 2018 12:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants