Skip to content
This repository has been archived by the owner on Mar 10, 2020. It is now read-only.

Nested Json Data access #570

Merged
merged 4 commits into from
Feb 7, 2019
Merged

Conversation

Blackbaud-BrandonJones
Copy link
Contributor

We allow users to create nested json structures in their stache data files. Our service gave no way of retrieving those nested data values from the methods provided. This change allows users to pass in a string of nested json data to retrieve the value, or a new method for accessing these values from an array.

stache.jsonData.global.nested.list.3.name for example.

@codecov-io
Copy link

codecov-io commented Jan 28, 2019

Codecov Report

Merging #570 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #570   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          88     88           
  Lines        1432   1443   +11     
  Branches      172    174    +2     
=====================================
+ Hits         1432   1443   +11
Impacted Files Coverage Δ
...app/public/src/modules/shared/json-data.service.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 854b426...9e04b23. Read the comment docs.

@Blackbaud-BrandonJones Blackbaud-BrandonJones merged commit 1e2a83e into master Feb 7, 2019
@Blackbaud-BrandonJones Blackbaud-BrandonJones deleted the feature-nested-data branch February 7, 2019 13:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants