Support connect attributes #164
Conversation
|
Hi! |
The first element of std::env::args_os() is usually the path of the executable. However it may not exist.
| @@ -242,6 +243,25 @@ impl<'a> Drop for Transaction<'a> { | |||
| } | |||
| } | |||
|
|
|||
| // length of length encoded integer | |||
| fn lenenc_int_len(x: usize) -> usize { | |||
There was a problem hiding this comment.
Please add the following todo comment. I'll move this to mysql_common crate later.
| fn lenenc_int_len(x: usize) -> usize { | |
| // TODO: Move to mysql_common | |
| fn lenenc_int_len(x: usize) -> usize { |
| } | ||
|
|
||
| // length of length encoded string | ||
| fn lenenc_str_len(s: &str) -> usize { |
There was a problem hiding this comment.
Please add the following todo comment. I'll move this to mysql_common crate later.
| fn lenenc_str_len(s: &str) -> usize { | |
| // TODO: Move to mysql_common | |
| fn lenenc_str_len(s: &str) -> usize { |
| let value = env::var(name).expect(&format!("Could not get the environment variable {}", name)); | ||
| println!("cargo:rustc-env={}={}", name, value); | ||
| } | ||
| } |
There was a problem hiding this comment.
Could you please apply the diff as suggested by rustfmt here.
There was a problem hiding this comment.
I did it. See the second commit.
|
Thanks for accepting it. I found a issue about tests. When the system variable |
|
Ok, thanks. I'll wait for it. |
This PR add connect attributes support as Perl DBD::MySQL.
I confirmed that this passes a test by
cargo test connect_attrsfor MySQL 5.7.build.rswas added to gettarget_osandtarget_archcfg features as string values.The followings is the doc comment of
Opts.connect_attrsConnect attributes
This value is sent to the server as custom name-value attributes.
You can see them from performance_schema tables:
session_account_connect_attrsand
session_connect_attrswhen the server is MySQL 5.6 or later,or MariaDB 10.0 or later.
Note
Attribute names that begin with an underscore (
_) are not set byapplication programs because they are reserved for internal use.
The following attributes are sent in addition to ones set by programs.
rust-mysql-simple)target_oscfg feature)target_archcfg feature)std::env::argsif program_name isn't set by programs.